Fixed clippy warnings

This commit is contained in:
Andrew Kane
2022-09-23 14:04:34 -07:00
parent 4c92b71187
commit 51300f309d
3 changed files with 11 additions and 5 deletions

View File

@@ -2,7 +2,7 @@ use std::error;
use std::ffi::NulError; use std::ffi::NulError;
use std::fmt; use std::fmt;
#[derive(Debug, PartialEq)] #[derive(Debug, Eq, PartialEq)]
pub enum Error { pub enum Error {
Io, Io,
Parameter(String), Parameter(String),

View File

@@ -37,6 +37,12 @@ impl Matrix {
} }
} }
impl Default for Matrix {
fn default() -> Self {
Self::new()
}
}
#[cfg(test)] #[cfg(test)]
mod tests { mod tests {
use crate::Matrix; use crate::Matrix;

View File

@@ -70,24 +70,24 @@ impl Model {
unsafe { std::slice::from_raw_parts((*self.model).q, (self.columns() * self.factors()) as usize) } unsafe { std::slice::from_raw_parts((*self.model).q, (self.columns() * self.factors()) as usize) }
} }
pub fn p(&self, row_index: i32) -> Option<&[f32]>{ pub fn p(&self, row_index: i32) -> Option<&[f32]> {
if row_index >= 0 && row_index < self.rows() { if row_index >= 0 && row_index < self.rows() {
let factors = self.factors(); let factors = self.factors();
let start_index = factors as usize * row_index as usize; let start_index = factors as usize * row_index as usize;
let end_index = factors as usize * (row_index as usize + 1); let end_index = factors as usize * (row_index as usize + 1);
return Some(&self.p_factors()[start_index..end_index]); return Some(&self.p_factors()[start_index..end_index]);
} }
return None; None
} }
pub fn q(&self, column_index: i32) -> Option<&[f32]>{ pub fn q(&self, column_index: i32) -> Option<&[f32]> {
if column_index >= 0 && column_index < self.columns() { if column_index >= 0 && column_index < self.columns() {
let factors = self.factors(); let factors = self.factors();
let start_index = factors as usize * column_index as usize; let start_index = factors as usize * column_index as usize;
let end_index = factors as usize * (column_index as usize + 1); let end_index = factors as usize * (column_index as usize + 1);
return Some(&self.q_factors()[start_index..end_index]); return Some(&self.q_factors()[start_index..end_index]);
} }
return None; None
} }
pub fn rmse(&self, data: &Matrix) -> f64 { pub fn rmse(&self, data: &Matrix) -> f64 {