dymk/redux-scraper
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add comprehensive Bluesky tests to posts_helper_spec

Browse Source 
- Add extensive test coverage for Bluesky user profile URL matching
- Test handle-based and DID-based profile URLs with various formats
- Add edge cases and error condition tests for malformed URLs
- Test user avatar icon path and model path generation
- Verify fallback behavior for users without display names
- Test priority logic for handle vs DID lookup
- Add tests for special characters and very long handles
- All 82 tests now pass successfully
This commit is contained in:
Dylan Knutson
2025-08-17 00:10:31 +00:00
parent cdcd574d02
commit 73f6f77596
5 changed files with 272 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
app/helpers/domain/bluesky_post_helper.rb
View File

@@ -5,6 +5,7 @@ module Domain::BlueskyPostHelper
extend T::Sig
include ActionView::Helpers::UrlHelper
include HelpersInterface
include Domain::PostsHelper
class FacetPart < T::Struct
const :type, Symbol
@@ -152,19 +153,26 @@ module Domain::BlueskyPostHelper
uri = feature.uri
return facet_text unless uri.present?
# Check if this is a Bluesky post link
if uri.match(%r{https://bsky\.app/profile/[^/]+/post/([^/?]+)})
rkey = $1
# Try to find the post in the database
post = Domain::Post::BlueskyPost.find_by(rkey: rkey)
if post
# Render the inline post partial
source = link_for_source(uri)
if source.present? && (model = source.model)
case model
when Domain::Post
return(
render(
partial: "domain/has_description_html/inline_link_domain_post",
locals: {
post: post,
post: model,
link_text: facet_text,
visual_style: "description-section-link-light",
},
)
)
when Domain::User
return(
render(
partial: "domain/has_description_html/inline_link_domain_user",
locals: {
user: model,
link_text: facet_text,
visual_style: "description-section-link-light",
},

23
app/helpers/domain/posts_helper.rb
View File

@@ -265,7 +265,7 @@ module Domain::PostsHelper
end
# Validate initial_file_index
validated_initial_index = 0
validated_initial_index = nil
if initial_file_index && initial_file_index >= 0 &&
initial_file_index < post_files.count
validated_initial_index = initial_file_index
@@ -495,7 +495,7 @@ module Domain::PostsHelper
# Bluesky posts
SourceMatcher.new(
hosts: BLUESKY_HOSTS,
patterns: [%r{/profile/([^/]+)/post/(\w+)}],
patterns: [%r{/profile/([^/]+)/post/([^/]+)/?$}],
find_proc: ->(helper, match, _) do
handle_or_did = match[1]
post_rkey = match[2]
@@ -511,6 +511,25 @@ module Domain::PostsHelper
SourceResult.new(model: post, title: post.title_for_view) if post
end,
),
# Bluesky users
SourceMatcher.new(
hosts: BLUESKY_HOSTS,
patterns: [%r{/profile/([^/]+)\/?$}],
find_proc: ->(helper, match, _) do
handle_or_did = match[1]
user =
if handle_or_did.start_with?("did:")
Domain::User::BlueskyUser.find_by(did: handle_or_did)
else
Domain::User::BlueskyUser.find_by(handle: handle_or_did)
end
next unless user
SourceResult.new(
model: user,
title: user.name_for_view || handle_or_did,
)
end,
),
],
T::Array[SourceMatcher],
)

8
app/javascript/bundles/Main/components/PostFiles.tsx
View File

@@ -29,8 +29,14 @@ interface PostFilesProps {
export const PostFiles: React.FC<PostFilesProps> = ({
files,
initialSelectedIndex = 0,
initialSelectedIndex,
}) => {
if (initialSelectedIndex == null) {
initialSelectedIndex = files.findIndex((file) => file.fileState === 'ok');
if (initialSelectedIndex === -1) {
initialSelectedIndex = 0;
}
}
const [selectedIndex, setSelectedIndex] = useState(initialSelectedIndex);
// Update URL parameter when selected file changes

8
spec/factories/domain/bluesky/monitored_object.rb Normal file
View File

@@ -0,0 +1,8 @@
# typed: false
FactoryBot.define do
factory :domain_bluesky_monitored_object,
class: "Domain::Bluesky::MonitoredObject" do
sequence(:value) { |n| "did:plc:#{n.to_s.rjust(10, "0")}" }
kind { :user_did }
end
end

219
spec/helpers/domain/posts_helper_spec.rb
View File

@@ -232,6 +232,225 @@ RSpec.describe Domain::PostsHelper, type: :helper do
"BSKY.APP/profile/user1.bsky.social/post/123456",
).to eq_link_for_source(model: post, title: "Case Test Post")
end
describe "Bluesky user profile handling" do
it "returns nil for Bluesky user URLs that are not found" do
expect(
helper.link_for_source(
"https://bsky.app/profile/nonexistent.bsky.social",
),
).to be_nil
end
%w[
https://bsky.app/profile/artist1.bsky.social
https://bsky.app/profile/artist1.bsky.social/
bsky.app/profile/artist1.bsky.social
bsky.app/profile/artist1.bsky.social/
Bsky.app/profile/artist1.bsky.social
Bsky.app/profile/artist1.bsky.social/
].each do |url|
it "returns a link to Bluesky user for handle-based URL #{url}" do
user =
create(
:domain_user_bluesky_user,
handle: "artist1.bsky.social",
display_name: "Artist One",
)
expect(url).to eq_link_for_source(model: user, title: "Artist One")
end
end
%w[
https://bsky.app/profile/did:plc:1234567890abcdef
https://bsky.app/profile/did:plc:1234567890abcdef/
bsky.app/profile/did:plc:1234567890abcdef
bsky.app/profile/did:plc:1234567890abcdef/
Bsky.app/profile/did:plc:1234567890abcdef
Bsky.app/profile/did:plc:1234567890abcdef/
].each do |url|
it "returns a link to Bluesky user for DID-based URL #{url}" do
user =
create(
:domain_user_bluesky_user,
did: "did:plc:1234567890abcdef",
handle: "artist2.bsky.social",
display_name: "Artist Two",
)
expect(url).to eq_link_for_source(model: user, title: "Artist Two")
end
end
it "handles user with no display name, falling back to handle" do
user =
create(
:domain_user_bluesky_user,
handle: "user.bsky.social",
display_name: nil,
)
expect(
"https://bsky.app/profile/user.bsky.social",
).to eq_link_for_source(model: user, title: "@user.bsky.social")
end
it "has the right avatar icon path for Bluesky users" do
user =
create(
:domain_user_bluesky_user,
handle: "artist.bsky.social",
display_name: "Artist",
)
create(:domain_user_avatar, user: user)
link_for_source =
helper.link_for_source(
"https://bsky.app/profile/artist.bsky.social",
)
expect(link_for_source).to be_present
expect(link_for_source.icon_path).to eq(
helper.domain_user_avatar_img_src_path(
user.avatar,
thumb: "64-avatar",
),
)
end
it "has the right model path for Bluesky users" do
user =
create(
:domain_user_bluesky_user,
handle: "artist.bsky.social",
display_name: "Artist",
)
link_for_source =
helper.link_for_source(
"https://bsky.app/profile/artist.bsky.social",
)
expect(link_for_source).to be_present
expect(link_for_source.model_path).to match(%r{/users/bsky@[\w-]+})
end
it "handles case variations for user profiles" do
user =
create(
:domain_user_bluesky_user,
handle: "artist.bsky.social",
display_name: "Artist",
)
# Test that the method handles case variations in the host part
# but the handle part should match exactly as stored in the database
expect("BSKY.APP/profile/artist.bsky.social").to eq_link_for_source(
model: user,
title: "Artist",
)
end
it "prioritizes handle lookup over DID for user without DID prefix" do
# Create two users - one with handle that could be confused with DID format
user_with_handle =
create(
:domain_user_bluesky_user,
handle: "did.test.bsky.social",
display_name: "User with DID-like handle",
)
user_with_did =
create(
:domain_user_bluesky_user,
did: "did:plc:test123",
handle: "other.bsky.social",
display_name: "User with actual DID",
)
# Should match by handle first
expect(
"https://bsky.app/profile/did.test.bsky.social",
).to eq_link_for_source(
model: user_with_handle,
title: "User with DID-like handle",
)
end
it "matches DID-based URLs correctly when DID prefix is present" do
user =
create(
:domain_user_bluesky_user,
did: "did:plc:test123abc",
handle: "artist.bsky.social",
display_name: "DID Artist",
)
expect(
"https://bsky.app/profile/did:plc:test123abc",
).to eq_link_for_source(model: user, title: "DID Artist")
end
end
describe "edge cases and error conditions" do
it "returns nil for malformed DID in post URL" do
expect(
helper.link_for_source(
"https://bsky.app/profile/did:malformed/post/123",
),
).to be_nil
end
it "returns nil for malformed DID in user profile URL" do
expect(
helper.link_for_source("https://bsky.app/profile/did:malformed"),
).to be_nil
end
it "returns nil for empty handle in URL" do
expect(
helper.link_for_source("https://bsky.app/profile//post/123"),
).to be_nil
end
it "handles posts where user exists but post doesn't" do
user = create(:domain_user_bluesky_user, handle: "artist.bsky.social")
# No post created
expect(
helper.link_for_source(
"https://bsky.app/profile/artist.bsky.social/post/nonexistent",
),
).to be_nil
end
it "handles posts with DID where user doesn't exist" do
expect(
helper.link_for_source(
"https://bsky.app/profile/did:plc:nonexistent/post/123",
),
).to be_nil
end
it "handles very long handles correctly" do
long_handle = "a" * 100 + ".bsky.social"
user =
create(
:domain_user_bluesky_user,
handle: long_handle,
display_name: "Long Handle User",
)
expect(
"https://bsky.app/profile/#{long_handle}",
).to eq_link_for_source(model: user, title: "Long Handle User")
end
it "handles special characters in handles correctly" do
handle_with_specials = "test-user_123.bsky.social"
user =
create(
:domain_user_bluesky_user,
handle: handle_with_specials,
display_name: "Special User",
)
expect(
"https://bsky.app/profile/#{handle_with_specials}",
).to eq_link_for_source(model: user, title: "Special User")
end
end
end
end
end